You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: preserve numeric percentages in company CSV exports - #1454
The company CSV export was adding a literal apostrophe to generated changes such as +50% and -50%. Keep these calculated percentages intact while continuing to escape company names and other source text.
Replaces #1452 after its parent was squash-merged. This carries only the same one-line fix onto current main.
AI review notes:
Five source-derived CSV formatting/parsing cases passed for positive, negative, zero, New, and N/A values. A formula-like company name remains escaped. The prior expression produces the unwanted apostrophe. This is a source-level check, not a rendered browser test.
Full repository checks passed through normal commit hooks on main 8bd5925: types, lint, unit, chat, and desktop tests.
Summary by CodeRabbit
Bug Fixes
CSV exports now include the same Change value shown for each visitor in the live visitors view. This keeps exported growth labels consistent with their on-screen presentation and makes the exported data easier to compare with the displayed visitor information.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix: preserve numeric percentages in company CSV exports" matches the changeset. The one-line change in src/components/admin/LiveVisitors.tsx writes the Change value from growthLabel(row) d…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix: preserve numeric percentages in company CSV exports" matches the changeset. The one-line change in src/components/admin/LiveVisitors.tsx writes the Change value from growthLabel(row) directly instead of passing it through csvSafeText, so values such as +50% and -50% keep their numeric form in the CSV export. The title names the main behavior change and the affected export. It is specific and concise, and it does not describe anything absent from the changeset.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The company CSV export was adding a literal apostrophe to generated changes such as +50% and -50%. Keep these calculated percentages intact while continuing to escape company names and other source text.
Replaces #1452 after its parent was squash-merged. This carries only the same one-line fix onto current main.
Summary by CodeRabbit