Repository navigation
Conversation
rihokirss
force-pushed
the
codex/ids-partof
branch
from
November 7, 2026 18:46
adcbb10 to
cce1f7c
Compare
rihokirss
marked this pull request as draft
November 7, 2026 19:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the missing IDS 1.0
partOffacet (part of #830 and #831).The facet now selects applicable entities and evaluates required/prohibited relationships through aggregates, containment, nesting, groups, and opening/filling relationships. It traverses parent relations transitively, guards cycles, supports non-geometric items, checks the target entity and predefined type through the existing entity facet, and serializes the facet for both applicability and requirements.
The new test imports all 33 unchanged buildingSMART
partofIFC/IDS pairs with the necessary relation mappings enabled. All 33 test cases fail on the previous implementation (missing verdicts or missing serialized facets) and pass with the change. Fixtures retain their original license and source revision. Consumers need the corresponding relations retained by their IFC importer; the test demonstrates that configuration.Validation: all 47 IDS tests pass;
tsc -p tsconfig-build.json --noEmitpasses; ESLint passes for the changed TypeScript files.This PR does not change applicability conjunction or specification cardinality; those are addressed by #814 and #851/#852.