Repository navigation
Conversation
rihokirss
marked this pull request as draft
November 7, 2026 19:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds attribute-based applicability selection and corrects attribute presence/value checks. GlobalId is read from the Fragments GUID metadata. Required reference and select attributes pass when populated; null optional attributes pass while populated empty attributes must satisfy their value restriction.
This branch depends on #822 and includes its two commits unchanged. It addresses attribute applicability in #831.
Validation: 45 unchanged public buildingSMART attribute fixtures pass (four failed before this change). Each fixture additionally compares attribute applicability against direct required-facet evaluation over all imported entities, including objects without geometry. The full IDS suite passes (62 tests), core TypeScript compilation passes, and ESLint passes for the changed TypeScript files.