Skip to content

daemon: increase fallback polling interval - #285

Merged
HarshwardhanPatil07 merged 2 commits into
bootc-dev:mainfrom
HarshwardhanPatil07:fix/external-bootc-status-flake
Nov 3, 2026
Merged

HarshwardhanPatil07 merged 2 commits into
bootc-dev:mainfrom
HarshwardhanPatil07:fix/external-bootc-status-flake

Conversation

@HarshwardhanPatil07

Copy link
Copy Markdown
Member

Fixes: #284

Comment thread internal/daemon/watcher.go Resolved
@alicefr

alicefr commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

@HarshwardhanPatil07 please change only the timeout for the tests not for the default

@HarshwardhanPatil07
HarshwardhanPatil07 force-pushed the fix/external-bootc-status-flake branch from 6d789c9 to ab8ff23 Compare November 2, 2026 12:36
alicefr
alicefr previously approved these changes Nov 2, 2026
@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

increased the e2e timeout

alicefr
alicefr previously approved these changes Nov 3, 2026
Worker provisioning and staging can exceed the five-minute polling bound in TestExternalBootcStatusChange. Configure a ten-minute interval in the bink E2E deployment and preserve it through operator upgrades, while keeping the production default at five minutes.

Expose optional daemon arguments in the Helm chart and use the same E2E setting for deployment and the test assertion. The test remains parallel and verifies the running daemon received the configured interval.

Fixes: bootc-dev#284

Assisted-by: AI
Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
The Kubernetes 1.35 E2E job exceeded its 75-minute limit while tests were still running. Allow 105 minutes for the job so the existing 90-minute Go test timeout has room for cluster setup and cleanup.

Assisted-by: AI
Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

sorry the other pr merge caused the merged conflict #277

@alicefr alicefr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@HarshwardhanPatil07
HarshwardhanPatil07 merged commit 19d06ff into bootc-dev:main Nov 3, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestExternalBootcStatusChange is flaky

2 participants