Skip to content

fix(ssh): emit explicit warning when private-key input is empty (#74) - #122

Open
jaharoni wants to merge 1 commit into
deployphp:masterfrom
WholeTroutMedia:fix/issue-74-warn-empty-private-key
Open

jaharoni wants to merge 1 commit into
deployphp:masterfrom
WholeTroutMedia:fix/issue-74-warn-empty-private-key

Conversation

@jaharoni

@jaharoni jaharoni commented Nov 2, 2026 •

Copy link
Copy Markdown

Fixes #74

Summary

Emits an explicit @actions/core warning when skip-ssh-setup is false (default) and private-key is empty (for example, when ${{ secrets.PRIVATE_KEY }} evaluates to an empty string due to a secret name typo or missing repository/environment secret, as reported in #74):

  • Previously, ssh() started ssh-agent ($ ssh-agent -a /tmp/ssh-auth.sock), exported SSH_AUTH_SOCK, and silently skipped ssh-add - when private-key was empty, leaving users puzzled by downstream Permission denied (publickey,password) errors.
  • Now logs a clear GitHub Actions warning annotation (No "private-key" input provided (or the referenced GitHub Actions secret is empty). Proceeding without adding an SSH key to ssh-agent.) so misconfigured secret names are immediately obvious in the workflow run log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Puzzling ssh fail

1 participant