Skip to content

fix(ssh): emit explicit warning when private-key input is empty (#74) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaharoni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ssh): emit explicit warning when private-key input is empty (#74) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16163,6 +16163,9 @@ function setFailed(message) {
function error(message, properties = {}) {
issueCommand("error", toCommandProperties(properties), message instanceof Error ? message.toString() : message);
}
function warning(message, properties = {}) {
issueCommand("warning", toCommandProperties(properties), message instanceof Error ? message.toString() : message);
}
//#endregion
//#region node_modules/zx/build/deno.js
if (globalThis.Deno) {
Expand Down Expand Up @@ -36654,6 +36657,8 @@ async function ssh() {
p.stdin.write(privateKey);
p.stdin.end();
await p;
} else {
warning("No \"private-key\" input provided (or the referenced GitHub Actions secret is empty). Proceeding without adding an SSH key to ssh-agent.");
}
const knownHosts = getInput("known-hosts");
if (knownHosts !== "") {
Expand Down
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ async function ssh(): Promise<void> {
p.stdin.write(privateKey)
p.stdin.end()
await p
} else {
core.warning(
'No "private-key" input provided (or the referenced GitHub Actions secret is empty). Proceeding without adding an SSH key to ssh-agent.',
)
}

const knownHosts = core.getInput('known-hosts')
Expand Down