Repository navigation
Conversation
Remove the experimental designation from the ignored span origin configuration APIs for the v9 release.
adinauer
marked this pull request as ready for review
October 30, 2026 09:33
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
October 30, 2026 09:34
📲 Install BuildsAndroid
|
runningcode
reviewed
Oct 30, 2026
| * @param ignoredSpanOrigins the list of strings/regex patterns | ||
| */ | ||
| @ApiStatus.Experimental | ||
| public void setIgnoredSpanOrigins(final @Nullable List<String> ignoredSpanOrigins) { |
Contributor
There was a problem hiding this comment.
Is it intentional that the getter and setter have different types?
getIgnoredSpanOrigins returns List<FilterString>
setIgnoredSpanOrigins takes List<String>
this makes the API non symetrical and makes the kotlin synthetic accessors half work
Member
Author
There was a problem hiding this comment.
Yes, it's been this way for a while.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Promote the ignored span origin configuration APIs by removing their experimental designation:
SentryOptions.getIgnoredSpanOrigins()SentryOptions.addIgnoredSpanOrigin(...)SentryOptions.setIgnoredSpanOrigins(...)💡 Motivation and Context
These configuration APIs are ready to be part of the stable public API for the v9 release.
💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew :sentry:test --tests io.sentry.SentryOptionsTest --tests io.sentry.util.SpanUtilsTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.