Skip to content

ref(tracing): Promote ignored span origin APIs #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adinauer wants to merge 2 commits into
base: 9.x.x
Choose a base branch
from
+5 −4
Open

ref(tracing): Promote ignored span origin APIs #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5890de
ref(tracing): Promote ignored span origin APIs
adinauer Oct 30, 2026
c46f009
changelog
adinauer Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
- Remove deprecated OpenTelemetry integration classes and the legacy `SentrySpanStorage` ([#6243](https://github.com/getsentry/sentry-java/pull/6243))
- Decide whether foregrounding the app starts a new session on a monotonic clock instead of the wall clock, so that a device time change no longer starts a session that should have been resumed, or resumes one that should have ended. This affects session counts ([#6096](https://github.com/getsentry/sentry-java/pull/6096))

### Improvements

- Promote ignored span origin configuration APIs from experimental to stable ([#6427](https://github.com/getsentry/sentry-java/pull/6427))

## 8.62.0

### Improvements
Expand Down
5 changes: 1 addition & 4 deletions sentry/src/main/java/io/sentry/SentryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ public class SentryOptions implements RateLimiterConfig {
* Strings or regex patterns that the origin of a new span/transaction will be tested against. If
* there is a match, the span/transaction will not be created.
*/
@ApiStatus.Experimental private @Nullable List<FilterString> ignoredSpanOrigins = null;
private @Nullable List<FilterString> ignoredSpanOrigins = null;

/**
* Strings or regex patterns that captured transaction names will be tested against. If there is a
Expand Down Expand Up @@ -2949,7 +2949,6 @@ public void setSendModules(boolean sendModules) {
*
* @return the list of strings or regex patterns
*/
@ApiStatus.Experimental
public @Nullable List<FilterString> getIgnoredSpanOrigins() {
return ignoredSpanOrigins;
}
Expand All @@ -2960,7 +2959,6 @@ public void setSendModules(boolean sendModules) {
*
* @param ignoredSpanOrigin the string/regex pattern
*/
@ApiStatus.Experimental
public void addIgnoredSpanOrigin(String ignoredSpanOrigin) {
if (ignoredSpanOrigins == null) {
ignoredSpanOrigins = new ArrayList<>();
Expand All @@ -2974,7 +2972,6 @@ public void addIgnoredSpanOrigin(String ignoredSpanOrigin) {
*
* @param ignoredSpanOrigins the list of strings/regex patterns
*/
@ApiStatus.Experimental
public void setIgnoredSpanOrigins(final @Nullable List<String> ignoredSpanOrigins) {

@runningcode runningcode Oct 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that the getter and setter have different types?
getIgnoredSpanOrigins returns List<FilterString>
setIgnoredSpanOrigins takes List<String>

this makes the API non symetrical and makes the kotlin synthetic accessors half work

@adinauer adinauer Oct 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's been this way for a while.

if (ignoredSpanOrigins == null) {
this.ignoredSpanOrigins = null;
Expand Down
Loading