Repository navigation
Conversation
Allow stateful event processors to create independent instances when scopes are cloned while preserving existing sharing behavior by default. Reuse the original processor on recoverable extension failures so scope cloning remains host-safe. Refs GH-6365 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Scope-Based Deduplication)
📜 Description
Add a default
EventProcessor.fork()lifecycle contract and invoke it whenever aScopeis cloned. Preserve processor ordering and reuse the original processor if customer extension code returnsnullor fails recoverably.💡 Motivation and Context
Stateful event processors need independent state when isolation scopes are cloned, while existing stateless and customer-defined processors must remain shared by default. This establishes the lifecycle primitive needed for request-local duplicate event detection.
refs: #6365
💚 How did you test it?
./gradlew :sentry:test./gradlew spotlessApply :sentry:updateKotlinAbiCombinedScopeViewcloning.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The next PR adds the internal scope-based duplicate event processor using this fork contract.
#skip-changelog