Skip to content

Track successful DAP resume responses without continued events - #186

Merged
Oz Zafar (ozzafar) merged 1 commit into
mainfrom
fix/177-resume-response-state
Oct 25, 2026
Merged

Oz Zafar (ozzafar) merged 1 commit into
mainfrom
fix/177-resume-response-state

Conversation

@ozzafar

Copy link
Copy Markdown
Contributor

Summary

Fixes #177.

  • Correlate outbound continue/next/stepIn/stepOut/stepBack/reverseContinue/goto/restartFrame requests with successful adapter responses.
  • Clear paused state even when the adapter correctly omits a continued event.
  • Respect continue response allThreadsContinued and single-thread step requests.
  • Preserve failed-request state and stops arriving before their response, including newer stops on other threads.
  • Bound pending-request storage and discard it with the session; ignore unrelated and malformed responses.
  • Preserve existing explicit continued-event behavior.

Validation

  • npm run compile and npm run lint passed.
  • 128 focused extension-host tests passed (tracker, status, handler, restart), including the actual executor suppressing stale UI frames after a response-only resume.
  • git diff --check passed.
  • Real Lua/LÖVE adapter reproduction was not available in the connected workspace; tests feed the reported standard DAP message sequence to the actual tracker.

Existing PR check

No matching open PR was found. PR #26 concerns continuing an already-running target rather than response-driven execution tracking. This PR is independent of #184 and #185.

Not merged; awaiting maintainer confirmation.

Correlate resume requests with successful responses so adapters need not emit continued events. Respect thread-specific resumes and preserve stops arriving before acknowledgement.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a882e001-7e0e-4256-8a20-8eaec9c947f4
@github-actions

Copy link
Copy Markdown

✅ Extension Build Successful!

📦 VSIX artifact is ready for download

👉 View artifacts

Scroll down to the "Artifacts" section and download extension-vsix

To install: In VS Code, run Extensions: Install from VSIX... and select the downloaded file.

@ozzafar
Oz Zafar (ozzafar) merged commit 91e4282 into main Oct 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A successful continue or step response should clear the tracked paused state (adapters need not send a continued event)

1 participant