Skip to content

Trim unused skills, controls, and prompt bloat - #807

Merged
kixelated merged 7 commits into
mainfrom
quest/m0/trim-skills
Nov 22, 2026
Merged

kixelated merged 7 commits into
mainfrom
quest/m0/trim-skills

Conversation

@kixelated

@kixelated kixelated commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

Ships eight skills instead of fourteen (plan, run, afk, start, iterate, review, merge, import), as planned in moq-dev/quest#796, and trims always-loaded prose.

Changes

  • Removed skills: export, spawn, delete, recurring, complete.
    • /quest-run gains a ## Waits section, taken from complete.md: it reads quest waiting --json, checks each condition, asks the maintainer's items in the round, and sends quest edits to a quest-run/<slug> PR. A filter argument such as prs keeps it from starting quests, which covers what /quest-complete was used for. The run finishes only once every wait in scope is settled, and the summary lists the waits.
    • Recurring-quest planning (where the next run goes, what gates it, removing a recurring gate's path from Required, shipped audit stubs) is now one paragraph in plan.md.
    • Abandoning a quest moved into the guide's ## Deletion section: run quest rm, put the deletion in its own PR or reuse the quest's open PR, and treat the user's pick to delete as the pick to merge. That rule covers only a quest the user picks to delete; a planning or waits PR deletes quests among its other edits. Pullfrog caught the conflict with the Waits PR. run and merge now load Deletion. The merge and review pick options say "delete" instead of /quest-delete.
    • afk.md no longer points to /quest-complete: when the user returns, it resumes the session's skill, or runs /quest-run on the blockers.
  • grill is internal now: src/cli/skills.ts keeps it in an INTERNAL list. It still composes into plan, iterate, and run under a # The grill skill heading, but it gets no installed stub, quest skill doesn't list it, and quest skill grill gives an error.
  • Guide (assets/AGENTS.md): removed the unused "pause" control. The quest agent start paragraph now points to its --help instead of repeating its flags. The /quest-complete and /quest-recurring mentions now say /quest-run.
  • assets/CONTEXT.md trims: dropped the .tmp/ sentence, which the tmp hook already enforces. Merged the Quests section into two lines. Shortened a few wordy lines (link format, quest wait, Caused by, base merges). Nothing of substance was removed. docs/context.md is regenerated.
  • This repository's stubs: quest init deleted the retired stubs itself. It already removes stubs of skills a version no longer ships, so no new cleanup code was needed.
  • README, tests, and scripts/lifecycle-check.mjs are updated to the new skill set. SETUP.md's Remove steps no longer run quest skill export, which the first review round caught. quest/m0/trim-skills.md is deleted, along with the Required links to it in afk-and-waits.md and dialog-options.md.

Public API: the quest skill names complete, delete, export, recurring, spawn, and grill are gone, and quest init removes their stubs. Wire impact: none.

Choices for review

  • src/cli/records.ts keeps the role mappings for the retired skills. quest usage reads transcripts from the last weeks, which still run them, so dropping the mappings would misattribute roles in the arm A/B data. The README's role list stays accurate for the same reason.

  • examples/export/ stays. It is the CSV-export sample project the README and just check use, not /quest-export.

  • In run.md, I left the standing-pick paragraph alone so it doesn't conflict with moq-dev/quest#802. In CONTEXT.md, I left the Questions and stall lines alone for moq-dev/quest#806.

  • Coordinator's choice, for review (the user was away; this is not a maintainer decision), on whether an upgrade removes the retired skills' stubs: ✅ keep the existing removal, where quest init deletes them and quest check flags them until it runs (rejected: make quest check and quest init skip the six retired names). The quest's "left alone, per AGENTS.md" means no cleanup code specific to these skills, which is AGENTS.md's "no migrations, shims, or cleanup of what earlier versions wrote", and this PR adds none. Removal has been general behavior since d7ef15e (src/core/init.ts:133-142). A stub kept installed would call a quest skill <name> that now fails. This PR deletes the quest file, so no quest text is left that reads as "keep them installed". The xhigh shadow reviewer kept its finding through three rounds because a coordinator's choice is not a maintainer decision. At its design checkpoint I compared the two approaches again: retiring a skill has to remove its stub, or the stub runs a skill that no longer exists, so the current approach stays. The user's merge pick confirms or reverses this choice.

  • Base merged with moq-dev/quest#802 (clean). Its Undo, risk-tier, and standing-pick text is kept as it landed.

  • Refuted on the latest round, with evidence in the review record: the .tmp/ line is a duplicate of the checked rule quest context still prints; "pause" was removed by the maintainer's quest: plan skill trimming, dialog options, afk/waits, and hooks #796 decision; run composes merge's landing-stopped line; internal grill cannot run alone; the retired role mappings stay for quest usage.

  • quest/m0/start-spend.md's non-goal now names this PR instead of the deleted quest file.

Validation

  • nix develop -c just check and nix develop -c just test pass after the base merge: 1564 tests, plus the install and lifecycle scripts on both builds.
  • On the real CLI: quest init in this checkout deleted the 12 retired stubs. quest skill lists afk import iterate merge plan review run start. quest skill grill exits 1 with no skill named grill.
  • Character counts (quest skill <name> | wc -c), before → after:
before after
CONTEXT.md (limit 10,000) 9,809 9,362
complete (limit 30,000) 29,734 removed
spawn 24,683 removed
recurring 16,227 removed
export 6,982 removed
delete 1,643 removed
grill 2,900 internal
run 24,150 25,331
review 20,271 20,654
iterate 16,593 16,490
import 15,409 16,371
plan 14,319 15,281
start 13,752 13,741
merge 9,634 10,032
afk 2,327 2,289

The largest composed skill dropped from 99.1% to 84.4% of INLINE_LIMIT. run grew by the Waits section it absorbed, and plan by the recurring paragraph.

Follow-ups

None.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S, arm A)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: b5c4d7d

  • Base: origin/main at 4f97561

  • Risk: high, it changes assets/CONTEXT.md, which is always high: every agent session in every repository using Quest loads these rules, including when it may write remotely or merge

  • Classified: high by the always-high paths

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a201fa-f51c-7032-805a-a0364ad28ffe, round 2

  • Score: 9/10, The incremental changes introduce no actionable regressions; static review found no blocking defects, and builds and tests were not run as instructed.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Claude Code, claude-sonnet-5-5, medium effort, second

  • Session: 237c2f61-786b-4b92-8e39-05cf976392e3, round 2

  • Score: 8/10, The two fixes hold and the refutations cite checkable evidence, so the remaining concerns are minor and the change lands as is.

  • Rounds: 2; first round 7 (high 1, medium 4, low 2); findings 7 (high 1, medium 4, low 2): fixed 2, refuted 5, open 0

  • Findings: none

  • The last round's findings, at d74b5b5:

    • Refuted: high, assets/CONTEXT.md:40: Workspace rule on .tmp/ scratch files removed from always-loaded context; docs/context.md:91 still carries the `.tmp/`, never `/tmp` rule under the checked rules that `quest context` prints, so the deleted line was a duplicate.
    • Refuted: medium, assets/AGENTS.md:217: 'pause' control removed from the coordination guide; The removal is a recorded maintainer decision in the quest's Goal (moq-dev/quest#796), backed by usage evidence, and free-text 'pause' remains ordinary input.
    • Refuted: medium, assets/skills/run.md:57: landing-stopped explanation dropped from /quest-run; run.md's front matter has `skills: grill, merge` and merge.md:42 still carries the `landing-stopped` line, so `quest skill run` prints it.
    • Fixed: low, quest/m0/start-spend.md:7: Dangling reference to deleted quest/m0/trim-skills.md; quest/m0/start-spend.md:7 now says the trimming was done in moq-dev/quest#807 instead of naming the deleted file.
    • Refuted: medium, assets/skills/grill.md:21: Grill lost its confirm-before-acting step; Grill is now an internal skill that cannot run on its own, and its callers (plan, iterate, run) each say how they record and act on decisions.
    • Fixed: medium, assets/AGENTS.md:196: Deletions-only PR rule conflicts with plan.md and run.md; The head's assets/AGENTS.md change limits the deletions-only PR rule to quests the user picks to delete, so planning and waits PRs can delete quests among other edits.
    • Refuted: low, src/cli/records.ts:8: Retired skills still listed; quest-run/ prefix not in PLANNING; The retired roles are kept on purpose for `quest usage` transcripts, and a session takes its role from its first skill, so the branch prefix is only a fallback.
  • Reviewer: Codex, gpt-6.1-sol, xhigh effort, shadow

  • Session: 01a201fa-f51c-7eb2-8fd6-0cb7ad099ff1

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

kixelated and others added 4 commits November 21, 2026 21:37
Quest-Claim: e7d77e2e608674bb
Ship eight skills: drop export, spawn, delete, recurring, and complete,
keep grill internal to the skills that interview, fold quest waiting into
/quest-run, recurring planning into /quest-plan, and abandonment into the
guide's Deletion. Remove the unused "pause" control and trim CONTEXT.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	quest/m0/trim-skills.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 22, 2026 05:59
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4a080136-76ab-41d0-b382-567a6502db26
Commits

Reviewing files that changed from the base of the PR and between 4f97561 and b5c4d7d.

Files selected for processing: 37

  • .agents/skills/quest-complete/SKILL.md
  • .agents/skills/quest-delete/SKILL.md
  • .agents/skills/quest-export/SKILL.md
  • .agents/skills/quest-grill/SKILL.md
  • .agents/skills/quest-recurring/SKILL.md
  • .agents/skills/quest-spawn/SKILL.md
  • .claude/skills/quest-complete/SKILL.md
  • .claude/skills/quest-delete/SKILL.md
  • .claude/skills/quest-export/SKILL.md
  • .claude/skills/quest-grill/SKILL.md
  • .claude/skills/quest-recurring/SKILL.md
  • .claude/skills/quest-spawn/SKILL.md
  • README.md
  • SETUP.md
  • assets/AGENTS.md
  • assets/CONTEXT.md
  • assets/skills/afk.md
  • assets/skills/complete.md
  • assets/skills/delete.md
  • assets/skills/export.md
  • assets/skills/grill.md
  • assets/skills/merge.md
  • assets/skills/plan.md
  • assets/skills/recurring.md
  • assets/skills/review.md
  • assets/skills/run.md
  • assets/skills/spawn.md
  • docs/context.md
  • quest/m0/afk-and-waits.md
  • quest/m0/dialog-options.md
  • quest/m0/start-spend.md
  • quest/m0/trim-skills.md
  • scripts/lifecycle-check.mjs
  • src/cli/records.ts
  • src/cli/skills.ts
  • test/cli.test.ts
  • test/skills.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ One rough edge worth a look, nothing else blocking.

Approach: sound. It folds the low-use skills into run, plan, and the guide's Deletion section, and makes grill a composition-only part, so the always-loaded and composed prompts get back their headroom without losing behavior.

Reviewed changes

This run reviewed the full diff at 73f43e3: the skill removals, the composition changes in skills.ts, and the prompt trims.

  • Retired skills: export, spawn, delete, recurring, and complete are removed, along with their stubs and their SKILLS entries.
  • Internal grill: a new INTERNAL list and part() lookup compose grill under # The grill skill, and it is not installed or listed. The startup validation now covers internal skills too.
  • run.md Waits: takes over complete.md's waits handling, loads Deletion, and makes the finish condition include waits.
  • plan.md recurring paragraph: replaces recurring.md.
  • Guide Deletion: takes over delete.md's rules (quest rm, a deletions-only PR, a delete pick that is also the merge pick). "pause" is removed, and quest agent start points to its --help.
  • CONTEXT.md trims: prose tightening, regenerated into docs/context.md.

I checked that review still gets Deletion for its new plain "delete" option: it composes merge, and compose collects guide sections across the whole chain.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using claude-opus-5-5 | 𝕏

Comment thread assets/skills/run.md Resolved
kixelated and others added 3 commits November 21, 2026 22:37
/quest-run's Waits PR deletes wait-only quests alongside other wait edits,
which the guide's Deletion section contradicted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Coordinator note (2026-11-22, /quest-run under /quest-afk merge, maintainer away): queueing this on the AFK merge grant, my recommendation.

On the retired-stubs choice: the maintainer's plan as first written in #796 (91cb66d) said "quest init cleans up the retired skill stubs" and "verify quest init removes the six retired stubs cleanly". The "left alone" wording came later, from an iterate on that PR answering a Pullfrog finding. Keeping quest init's existing removal restores the planned behavior, so this is not a maintainer decision; the maintainer can reverse it on return.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge November 22, 2026 06:44

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. The Waits-PR deletion conflict from the last round is resolved.

Reviewed changes

This run reviewed the changes since 73f43e3:

  • Scoped Deletion rule: assets/AGENTS.md now applies the deletions-only PR and the pick-to-merge rule only to a quest the user picks to delete at a pick. Planning and waits PRs delete quests among their other edits, so /quest-run's quest-run/<slug> PR and /quest-plan's PR no longer contradict the guide.
  • start-spend.md reference: the non-goal now links #807 instead of the deleted quest/m0/trim-skills.md.
  • Base merge: origin/main (#802) was merged in cleanly.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 22, 2026
Merged via the queue into main with commit dbe6aab Nov 22, 2026
20 checks passed
@kixelated
kixelated deleted the quest/m0/trim-skills branch November 22, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant