Repository navigation
Trim unused skills, controls, and prompt bloat - #807
Conversation
Quest-Claim: e7d77e2e608674bb
Ship eight skills: drop export, spawn, delete, recurring, and complete, keep grill internal to the skills that interview, fold quest waiting into /quest-run, recurring planning into /quest-plan, and abandonment into the guide's Deletion. Remove the unused "pause" control and trim CONTEXT.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # quest/m0/trim-skills.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
ℹ️ One rough edge worth a look, nothing else blocking.
Approach: sound. It folds the low-use skills into run, plan, and the guide's Deletion section, and makes grill a composition-only part, so the always-loaded and composed prompts get back their headroom without losing behavior.
Reviewed changes
This run reviewed the full diff at 73f43e3: the skill removals, the composition changes in skills.ts, and the prompt trims.
- Retired skills:
export,spawn,delete,recurring, andcompleteare removed, along with their stubs and theirSKILLSentries. - Internal
grill: a newINTERNALlist andpart()lookup composegrillunder# The grill skill, and it is not installed or listed. The startup validation now covers internal skills too. run.mdWaits: takes overcomplete.md's waits handling, loadsDeletion, and makes the finish condition include waits.plan.mdrecurring paragraph: replacesrecurring.md.- Guide
Deletion: takes overdelete.md's rules (quest rm, a deletions-only PR, a delete pick that is also the merge pick)."pause"is removed, andquest agent startpoints to its--help. CONTEXT.mdtrims: prose tightening, regenerated intodocs/context.md.
I checked that review still gets Deletion for its new plain "delete" option: it composes merge, and compose collects guide sections across the whole chain.
claude-opus-5-5 | 𝕏
/quest-run's Waits PR deletes wait-only quests alongside other wait edits, which the guide's Deletion section contradicted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Coordinator note (2026-11-22, On the retired-stubs choice: the maintainer's plan as first written in #796 ( (Written by Claude Opus 5.5) |
There was a problem hiding this comment.
✅ No new issues found. The Waits-PR deletion conflict from the last round is resolved.
Reviewed changes
This run reviewed the changes since 73f43e3:
- Scoped
Deletionrule:assets/AGENTS.mdnow applies the deletions-only PR and the pick-to-merge rule only to a quest the user picks to delete at a pick. Planning and waits PRs delete quests among their other edits, so/quest-run'squest-run/<slug>PR and/quest-plan's PR no longer contradict the guide. start-spend.mdreference: the non-goal now links #807 instead of the deletedquest/m0/trim-skills.md.- Base merge:
origin/main(#802) was merged in cleanly.
claude-opus-5-5 | 𝕏

Ships eight skills instead of fourteen (
plan,run,afk,start,iterate,review,merge,import), as planned in moq-dev/quest#796, and trims always-loaded prose.Changes
export,spawn,delete,recurring,complete./quest-rungains a## Waitssection, taken fromcomplete.md: it readsquest waiting --json, checks each condition, asks the maintainer's items in the round, and sends quest edits to aquest-run/<slug>PR. A filter argument such asprskeeps it from starting quests, which covers what/quest-completewas used for. The run finishes only once every wait in scope is settled, and the summary lists the waits.Required, shipped audit stubs) is now one paragraph inplan.md.## Deletionsection: runquest rm, put the deletion in its own PR or reuse the quest's open PR, and treat the user's pick to delete as the pick to merge. That rule covers only a quest the user picks to delete; a planning or waits PR deletes quests among its other edits. Pullfrog caught the conflict with the Waits PR.runandmergenow loadDeletion. The merge and review pick options say "delete" instead of/quest-delete.afk.mdno longer points to/quest-complete: when the user returns, it resumes the session's skill, or runs/quest-runon the blockers.grillis internal now:src/cli/skills.tskeeps it in anINTERNALlist. It still composes intoplan,iterate, andrununder a# The grill skillheading, but it gets no installed stub,quest skilldoesn't list it, andquest skill grillgives an error.assets/AGENTS.md): removed the unused"pause"control. Thequest agent startparagraph now points to its--helpinstead of repeating its flags. The/quest-completeand/quest-recurringmentions now say/quest-run.assets/CONTEXT.mdtrims: dropped the.tmp/sentence, which thetmphook already enforces. Merged the Quests section into two lines. Shortened a few wordy lines (link format,quest wait, Caused by, base merges). Nothing of substance was removed.docs/context.mdis regenerated.quest initdeleted the retired stubs itself. It already removes stubs of skills a version no longer ships, so no new cleanup code was needed.scripts/lifecycle-check.mjsare updated to the new skill set.SETUP.md's Remove steps no longer runquest skill export, which the first review round caught.quest/m0/trim-skills.mdis deleted, along with theRequiredlinks to it inafk-and-waits.mdanddialog-options.md.Public API: the
quest skillnamescomplete,delete,export,recurring,spawn, andgrillare gone, andquest initremoves their stubs. Wire impact: none.Choices for review
src/cli/records.tskeeps the role mappings for the retired skills.quest usagereads transcripts from the last weeks, which still run them, so dropping the mappings would misattribute roles in the arm A/B data. The README's role list stays accurate for the same reason.examples/export/stays. It is the CSV-export sample project the README andjust checkuse, not/quest-export.In
run.md, I left the standing-pick paragraph alone so it doesn't conflict with moq-dev/quest#802. InCONTEXT.md, I left the Questions and stall lines alone for moq-dev/quest#806.Coordinator's choice, for review (the user was away; this is not a maintainer decision), on whether an upgrade removes the retired skills' stubs: ✅ keep the existing removal, where
quest initdeletes them andquest checkflags them until it runs (rejected: makequest checkandquest initskip the six retired names). The quest's "left alone, perAGENTS.md" means no cleanup code specific to these skills, which is AGENTS.md's "no migrations, shims, or cleanup of what earlier versions wrote", and this PR adds none. Removal has been general behavior since d7ef15e (src/core/init.ts:133-142). A stub kept installed would call aquest skill <name>that now fails. This PR deletes the quest file, so no quest text is left that reads as "keep them installed". The xhigh shadow reviewer kept its finding through three rounds because a coordinator's choice is not a maintainer decision. At its design checkpoint I compared the two approaches again: retiring a skill has to remove its stub, or the stub runs a skill that no longer exists, so the current approach stays. The user's merge pick confirms or reverses this choice.Base merged with moq-dev/quest#802 (clean). Its Undo, risk-tier, and standing-pick text is kept as it landed.
Refuted on the latest round, with evidence in the review record: the
.tmp/line is a duplicate of the checked rulequest contextstill prints;"pause"was removed by the maintainer's quest: plan skill trimming, dialog options, afk/waits, and hooks #796 decision; run composes merge'slanding-stoppedline; internal grill cannot run alone; the retired role mappings stay forquest usage.quest/m0/start-spend.md's non-goal now names this PR instead of the deleted quest file.Validation
nix develop -c just checkandnix develop -c just testpass after the base merge: 1564 tests, plus the install and lifecycle scripts on both builds.quest initin this checkout deleted the 12 retired stubs.quest skilllistsafk import iterate merge plan review run start.quest skill grillexits 1 withno skill named grill.quest skill <name> | wc -c), before → after:CONTEXT.md(limit 10,000)The largest composed skill dropped from 99.1% to 84.4% of
INLINE_LIMIT.rungrew by the Waits section it absorbed, andplanby the recurring paragraph.Follow-ups
None.
Models
Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S, arm A)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: b5c4d7d
Base: origin/main at 4f97561
Risk: high,
it changes assets/CONTEXT.md, which is always high: every agent session in every repository using Quest loads these rules, including when it may write remotely or mergeClassified: high by the always-high paths
Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a201fa-f51c-7032-805a-a0364ad28ffe, round 2Score: 9/10,
The incremental changes introduce no actionable regressions; static review found no blocking defects, and builds and tests were not run as instructed.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Claude Code, claude-sonnet-5-5, medium effort, second
Session:
237c2f61-786b-4b92-8e39-05cf976392e3, round 2Score: 8/10,
The two fixes hold and the refutations cite checkable evidence, so the remaining concerns are minor and the change lands as is.Rounds: 2; first round 7 (high 1, medium 4, low 2); findings 7 (high 1, medium 4, low 2): fixed 2, refuted 5, open 0
Findings: none
The last round's findings, at d74b5b5:
assets/CONTEXT.md:40:Workspace rule on .tmp/ scratch files removed from always-loaded context;docs/context.md:91 still carries the `.tmp/`, never `/tmp` rule under the checked rules that `quest context` prints, so the deleted line was a duplicate.assets/AGENTS.md:217:'pause' control removed from the coordination guide;The removal is a recorded maintainer decision in the quest's Goal (moq-dev/quest#796), backed by usage evidence, and free-text 'pause' remains ordinary input.assets/skills/run.md:57:landing-stopped explanation dropped from /quest-run;run.md's front matter has `skills: grill, merge` and merge.md:42 still carries the `landing-stopped` line, so `quest skill run` prints it.quest/m0/start-spend.md:7:Dangling reference to deleted quest/m0/trim-skills.md;quest/m0/start-spend.md:7 now says the trimming was done in moq-dev/quest#807 instead of naming the deleted file.assets/skills/grill.md:21:Grill lost its confirm-before-acting step;Grill is now an internal skill that cannot run on its own, and its callers (plan, iterate, run) each say how they record and act on decisions.assets/AGENTS.md:196:Deletions-only PR rule conflicts with plan.md and run.md;The head's assets/AGENTS.md change limits the deletions-only PR rule to quests the user picks to delete, so planning and waits PRs can delete quests among other edits.src/cli/records.ts:8:Retired skills still listed; quest-run/ prefix not in PLANNING;The retired roles are kept on purpose for `quest usage` transcripts, and a session takes its role from its first skill, so the branch prefix is only a fallback.Reviewer: Codex, gpt-6.1-sol, xhigh effort, shadow
Session:
01a201fa-f51c-7eb2-8fd6-0cb7ad099ff1Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0