Skip to content

Mold common maintainer answers into dialog rules - #809

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/dialog-options
Nov 22, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/dialog-options

Conversation

@kixelated

@kixelated kixelated commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/dialog-options.md (planned in moq-dev/quest#796): question dialogs now offer the free-text answers the maintainer typed most often in the 2026-11-21 transcript audit.

Summary

  • Guide ## Questions (assets/AGENTS.md): two new lines.
    • A decision, plan, or follow-up dialog keeps one option for "Explain it first". It is defined once here: walk through the problem, current behavior, and each choice's trade-offs, then ask again without it.
    • A dialog for a step only the user can take offers, in order: the agent takes it (such as driving the browser) when it plausibly can; "Done / I'll do it now"; "Not at my PC (defer)", which keeps the wait and skips it for the session; and "Drop the wait".
  • /quest-plan (assets/skills/plan.md): the Goal prompt includes "Drop".
  • /quest-review (assets/skills/review.md): the stale /quest-merge / /quest-iterate / skip / delete bullet list is gone. The pick uses /quest-merge's options, and review.md keeps only when to recommend /quest-merge and when to recommend /quest-iterate.
  • /quest-merge (assets/skills/merge.md): its own "Explain it first" definition is dropped, since the guide's Questions section (which merge loads) now defines it. "Rethink it" stays.
  • Deletes the quest.

Choices made without asking

The user is away, so I took my recommendation on each:

  • Codex's dialog holds 2-3 options, not 4. I read the request_user_input schema in a recent Codex session: "Provide 2-3 mutually exclusive choices". So rule 1 says "keeps one option for Explain it first" rather than "2 to 3 concrete choices plus Explain". On a tool that holds only 3 options, the wait dialog leaves "Drop the wait" to the user's typed answer, since both tools add a free-text option.
  • A Maintainer: decision item is a decision dialog and follows rule 1. Rule 2 covers only steps the user must take. The two rule lines' scopes say this, without a separate sentence.
  • run.md is unchanged. Its Waits line "a skip stands for the session" agrees with the defer option, and quest/m0/afk-and-waits.md is concurrently editing that section.
  • Placement: the new Questions lines go after "Do not use asynchronous question tools.", not next to the "Recommend in every prompt" line that moq-dev/quest#806 changed. After Hold Stop on agent turns and waits, and require (Recommended) in question dialogs #806 landed, merging main conflicted only on the two quest files each PR deleted, and both deletions stand. With Hold Stop on agent turns and waits, and require (Recommended) in question dialogs #806's hook enforcing (Recommended), the new option labels still take that suffix where recommended.
  • No ## Caused by: review.md's list predates moq-dev/quest#768. That PR touched the line above the list but kept the list (older behavior), so it did not introduce the defect.

Public API

None: this changes only skill and guide prose. No wire impact.

Validation

  • just check and just test pass, before and after merging main with Hold Stop on agent turns and waits, and require (Recommended) in question dialogs #806 (55 files, 1567 passed, 5 skipped).
  • quest skill <name> composition: review, merge, plan, run, iterate, and start each include the new Questions lines. plan includes "Drop". No composed skill contains the old - skip: bullet. Largest is run at 25,910 characters, under INLINE_LIMIT (30,000).
  • Behavior, head vs base (differential): I fed claude -p --model sonnet each composed skill plus a scenario and asked for the AskUserQuestion options it would use.
    • Manual step (enable npm trusted publishing), head: Drive Chrome for me (Recommended) / Done / I'll do it now / Not at my PC (defer) / Drop the wait. Base: Drive Chrome for me / I did it myself / Skip for this session / Rethink it.
    • /quest-plan Goal round, head: Confirm goal (Recommended) / Adjust boundaries / Explain it first / Drop. Base: Confirm as written / Narrower / Broader / Different goal, with neither Explain nor Drop.

Follow-ups

None.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm B)

(Written by Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 5ad41cb

  • Base: origin/main at 69273a2

  • Risk: medium, If the new dialog rules or the trimmed review/merge option lists are misread, agent sessions in every repository using Quest would offer different or missing choices on decision and wait dialogs, which the maintainer could see as a wrong pick, but nothing that others build against changes and a revert of the assets/ edits restores the old behavior. No export, record, output, sandbox, credential, or remote-write authority changes, so it is not high; it is a behavior change in agent instructions, so it is not low.

  • Classified: medium by Claude Code, claude-haiku-5-5, low effort, session 2ae18d43-81cd-47b8-aa7f-d60125f64cb3

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a20227-f529-7842-942f-52743ed4cb23, round 2

  • Score: 10/10, The delta incorporates the specified base and removes a redundant recommendation reminder without introducing actionable defects; no builds or tests were run, as instructed.

  • Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, xhigh effort, shadow

  • Session: 01a20227-f527-7b71-be92-f9f244b44d63

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

kixelated and others added 3 commits November 21, 2026 23:23
Quest-Claim: 825e2f4e4bc23915
Add "Explain it first" to decision, plan, and follow-up dialogs, a
standard option set for steps only the user can take, and "Drop" on
/quest-plan's goal prompt. /quest-review asks the pick with
/quest-merge's options instead of its own stale list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	quest/m0/agent-and-question-hooks.md
#	quest/m0/dialog-options.md
@kixelated
kixelated marked this pull request as ready for review November 22, 2026 07:31
@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58fbce32-da24-4286-9a05-90b647f45347
Commits

Reviewing files that changed from the base of the PR and between 69273a2 and 5ad41cb.

Files selected for processing: 5

  • assets/AGENTS.md
  • assets/skills/merge.md
  • assets/skills/plan.md
  • assets/skills/review.md
  • quest/m0/dialog-options.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge November 22, 2026 07:32

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. It defines "Explain it first" once in the guide's ## Questions section, adds the manual-step option order there, and trims the duplicated option lists in review.md and merge.md.

Reviewed changes

  • Guide ## Questions (assets/AGENTS.md): adds the "Explain it first" rule for decision, plan, and follow-up dialogs, and an ordered option set for user-only steps, with "Drop the wait" left to typed answers on tools that hold fewer options.
  • merge.md: drops its own "Explain it first" definition, since the guide now defines it. "Rethink it" stays.
  • plan.md: the Goal round now includes "Drop" among its options.
  • review.md: replaces the stale option bullet list with a pointer to /quest-merge's options, keeping only when to recommend /quest-merge versus /quest-iterate.
  • quest/m0/dialog-options.md: deletes the finished quest.

This is prose only, and merge.md still names "Explain it first" in its option list, so the definition it now relies on lives in the guide.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 22, 2026
Merged via the queue into main with commit a88c65b Nov 22, 2026
25 checks passed
@kixelated
kixelated deleted the quest/m0/dialog-options branch November 22, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant