Repository navigation
Mold common maintainer answers into dialog rules - #809
Conversation
Quest-Claim: 825e2f4e4bc23915
Add "Explain it first" to decision, plan, and follow-up dialogs, a standard option set for steps only the user can take, and "Drop" on /quest-plan's goal prompt. /quest-review asks the pick with /quest-merge's options instead of its own stale list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # quest/m0/agent-and-question-hooks.md # quest/m0/dialog-options.md
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It defines "Explain it first" once in the guide's ## Questions section, adds the manual-step option order there, and trims the duplicated option lists in review.md and merge.md.
Reviewed changes
- Guide
## Questions(assets/AGENTS.md): adds the "Explain it first" rule for decision, plan, and follow-up dialogs, and an ordered option set for user-only steps, with "Drop the wait" left to typed answers on tools that hold fewer options. merge.md: drops its own "Explain it first" definition, since the guide now defines it. "Rethink it" stays.plan.md: the Goal round now includes "Drop" among its options.review.md: replaces the stale option bullet list with a pointer to/quest-merge's options, keeping only when to recommend/quest-mergeversus/quest-iterate.quest/m0/dialog-options.md: deletes the finished quest.
This is prose only, and merge.md still names "Explain it first" in its option list, so the definition it now relies on lives in the guide.
claude-sonnet-5-5 | 𝕏

Finishes
quest/m0/dialog-options.md(planned in moq-dev/quest#796): question dialogs now offer the free-text answers the maintainer typed most often in the 2026-11-21 transcript audit.Summary
## Questions(assets/AGENTS.md): two new lines./quest-plan(assets/skills/plan.md): the Goal prompt includes "Drop"./quest-review(assets/skills/review.md): the stale/quest-merge//quest-iterate/ skip / delete bullet list is gone. The pick uses/quest-merge's options, and review.md keeps only when to recommend/quest-mergeand when to recommend/quest-iterate./quest-merge(assets/skills/merge.md): its own "Explain it first" definition is dropped, since the guide's Questions section (which merge loads) now defines it. "Rethink it" stays.Choices made without asking
The user is away, so I took my recommendation on each:
request_user_inputschema in a recent Codex session: "Provide 2-3 mutually exclusive choices". So rule 1 says "keeps one option for Explain it first" rather than "2 to 3 concrete choices plus Explain". On a tool that holds only 3 options, the wait dialog leaves "Drop the wait" to the user's typed answer, since both tools add a free-text option.Maintainer:decision item is a decision dialog and follows rule 1. Rule 2 covers only steps the user must take. The two rule lines' scopes say this, without a separate sentence.run.mdis unchanged. Its Waits line "a skip stands for the session" agrees with the defer option, and quest/m0/afk-and-waits.md is concurrently editing that section.(Recommended), the new option labels still take that suffix where recommended.## Caused by: review.md's list predates moq-dev/quest#768. That PR touched the line above the list but kept the list (older behavior), so it did not introduce the defect.Public API
None: this changes only skill and guide prose. No wire impact.
Validation
just checkandjust testpass, before and after merging main with Hold Stop on agent turns and waits, and require (Recommended) in question dialogs #806 (55 files, 1567 passed, 5 skipped).quest skill <name>composition:review,merge,plan,run,iterate, andstarteach include the new Questions lines.planincludes "Drop". No composed skill contains the old- skip:bullet. Largest isrunat 25,910 characters, underINLINE_LIMIT(30,000).claude -p --model sonneteach composed skill plus a scenario and asked for theAskUserQuestionoptions it would use.Drive Chrome for me (Recommended)/Done / I'll do it now/Not at my PC (defer)/Drop the wait. Base:Drive Chrome for me/I did it myself/Skip for this session/Rethink it./quest-planGoal round, head:Confirm goal (Recommended)/Adjust boundaries/Explain it first/Drop. Base:Confirm as written/Narrower/Broader/Different goal, with neither Explain nor Drop.Follow-ups
None.
Models
Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm B)
(Written by Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 5ad41cb
Base: origin/main at 69273a2
Risk: medium,
If the new dialog rules or the trimmed review/merge option lists are misread, agent sessions in every repository using Quest would offer different or missing choices on decision and wait dialogs, which the maintainer could see as a wrong pick, but nothing that others build against changes and a revert of the assets/ edits restores the old behavior. No export, record, output, sandbox, credential, or remote-write authority changes, so it is not high; it is a behavior change in agent instructions, so it is not low.Classified: medium by Claude Code, claude-haiku-5-5, low effort, session
2ae18d43-81cd-47b8-aa7f-d60125f64cb3Reviewer: Codex, gpt-6.1-sol, high effort
Session:
01a20227-f529-7842-942f-52743ed4cb23, round 2Score: 10/10,
The delta incorporates the specified base and removes a redundant recommendation reminder without introducing actionable defects; no builds or tests were run, as instructed.Rounds: 2; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, xhigh effort, shadow
Session:
01a20227-f527-7b71-be92-f9f244b44d63Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0