Repository navigation
Conversation
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated producer, consumer and Streams templates show the invalid endpoint-identification algorithm
algo-namein commented TLS examples. Usehttpsconsistently with the corrected light-kafka defaults. Related: networknt/light-kafka#265.Keep these optional lines commented and retain the existing external override keys. Extend the existing real generation regression for both server/service generators and all eight Kafka flag combinations to check the emitted TLS examples, default injection and explicit empty opt-out. Document migration of previously uncommented examples and invalid overrides.
Validation on JDK 25.0.3 with the existing Maven cache:
mvn -o -q -pl light-hybrid-4j -am test: 26 tests passed, zero failures/errors/skips.mvn -o -q clean installis blocked by the pre-existingJackson3GeneratedBuildTest.restPomUsesJackson3AndJackson3LoggingEncoderassertion at line 47: it still expects json-schema-validator 3.0.8 although the template emits 3.0.9. Reproduced the same failure on untouched origin/master (30def5bb) withmvn -o -q -pl light-rest-4j -am test -Dtest=Jackson3GeneratedBuildTest -Dsurefire.failIfNoSpecifiedTests=false.git diff --checkpassed; staged impact analysis reports low risk.No production Java, dependency, workflow or schema-registration changes are included. The actual hostname match/mismatch handshake fixture is in the companion light-kafka PRs. light-example-4j is excluded; no deployment is included. Remote CI remains separate from local evidence.
Companion PRs: