Skip to content

Use https in generated Kafka TLS examples - #740

Closed
stevehu wants to merge 1 commit into
masterfrom
fix/265-ssl-hostname-verification
Closed

stevehu wants to merge 1 commit into
masterfrom
fix/265-ssl-hostname-verification

Conversation

@stevehu

@stevehu stevehu commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Generated producer, consumer and Streams templates show the invalid endpoint-identification algorithm algo-name in commented TLS examples. Use https consistently with the corrected light-kafka defaults. Related: networknt/light-kafka#265.

Keep these optional lines commented and retain the existing external override keys. Extend the existing real generation regression for both server/service generators and all eight Kafka flag combinations to check the emitted TLS examples, default injection and explicit empty opt-out. Document migration of previously uncommented examples and invalid overrides.

Validation on JDK 25.0.3 with the existing Maven cache:

  • mvn -o -q -pl light-hybrid-4j -am test: 26 tests passed, zero failures/errors/skips.
  • Full mvn -o -q clean install is blocked by the pre-existing Jackson3GeneratedBuildTest.restPomUsesJackson3AndJackson3LoggingEncoder assertion at line 47: it still expects json-schema-validator 3.0.8 although the template emits 3.0.9. Reproduced the same failure on untouched origin/master (30def5bb) with mvn -o -q -pl light-rest-4j -am test -Dtest=Jackson3GeneratedBuildTest -Dsurefire.failIfNoSpecifiedTests=false.
  • This draft is pending the separate baseline assertion repair; the TLS change does not alter that test.
  • git diff --check passed; staged impact analysis reports low risk.

No production Java, dependency, workflow or schema-registration changes are included. The actual hostname match/mismatch handshake fixture is in the companion light-kafka PRs. light-example-4j is excluded; no deployment is included. Remote CI remains separate from local evidence.

Companion PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant