Skip to content

Use https in generated Kafka TLS examples (2.x) - #741

Closed
stevehu wants to merge 1 commit into
2.xfrom
fix/265-ssl-hostname-verification-2x
Closed

stevehu wants to merge 1 commit into
2.xfrom
fix/265-ssl-hostname-verification-2x

Conversation

@stevehu

@stevehu stevehu commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Generated producer, consumer and Streams templates show the invalid endpoint-identification algorithm algo-name in commented TLS examples. Use https consistently with the corrected light-kafka defaults. Related: networknt/light-kafka#265.

Keep these optional lines commented and retain the existing external override keys. Extend the existing real generation regression for both server/service generators and all eight Kafka flag combinations to check the emitted TLS examples, default injection and explicit empty opt-out. Document migration of previously uncommented examples and invalid overrides.

Validation on JDK 25.0.3 with the existing Maven cache:

  • Full mvn -o -q clean install: 65 tests, zero failures/errors, 6 skipped.
  • Focused hybrid reactor validation also passed: 13 tests, no failures/errors/skips.
  • git diff --check passed; staged impact analysis reports low risk.

No production Java, dependency, workflow or schema-registration changes are included. The actual hostname match/mismatch handshake fixture is in the companion light-kafka PRs. light-example-4j is excluded; no deployment is included. Remote CI remains separate from local evidence.

Companion PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant