Skip to content

Conditional questions: date and time as trigger - #3835

Open
AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-2-checkboxesfrom
feat/conditional-questions-3-date-time
Open

AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-2-checkboxesfrom
feat/conditional-questions-3-date-time

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Part 3 of the conditional questions stack from #3123 (by Micke Nordin, with fixes by TimedIn and the review fixes). Based on #3834; the "Files changed" tab shows only this part.

Stack

  1. Conditional questions: base implementation plus support for radio and dropdown triggers #3833 Conditional questions: radio and dropdown triggers
  2. Conditional questions: checkboxes as trigger #3834 Conditional questions: checkboxes as trigger
  3. Conditional questions: date and time as trigger #3835 Conditional questions: date and time as trigger ← this PR
  4. Conditional questions: file upload as trigger #3836 Conditional questions: file upload as trigger
  5. Conditional questions: linear scale and color as trigger #3837 Conditional questions: linear scale and color as trigger
  6. Conditional questions: short and long text as trigger #3838 Conditional questions: short and long text as trigger

This PR

A date or time trigger shows a branch when the answer lies within the range of a condition, its bounds included.

  • bounds are stored in the answer format (YYYY-MM-DD, HH:mm) and are optional;
  • the server also accepts the deprecated datetime type, which the editor does not offer;
  • the date pickers of the condition editor are labelled;
  • docs and tests, including a range of a single day.

Tests

  • Unit tests: 611, all passing except the 15 IUserFolder errors main has as well.
  • php-cs-fixer, eslint and the build are clean.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 61.90% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from a9f1f27 to f0235a8 Compare November 4, 2026 14:07
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-2-checkboxes branch 2 times, most recently from 924a809 to d06f7a4 Compare November 4, 2026 14:20
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from f0235a8 to a5dc275 Compare November 4, 2026 14:20
A date or time trigger activates a branch when the answer lies within
the range of a condition, its bounds included. Bounds are stored in
the answer format (YYYY-MM-DD, HH:mm) and are optional. The server
also accepts the deprecated datetime type, which the editor does not
offer.

The code comes from the original pull request #3123 by Micke Nordin
and TimedIn, with the review fixes applied.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-2-checkboxes branch from d06f7a4 to fc6e821 Compare November 4, 2026 16:51
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from a5dc275 to 62a5b50 Compare November 4, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant