Skip to content

Conditional questions: file upload as trigger - #3836

Open
AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-3-date-timefrom
feat/conditional-questions-4-file
Open

AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-3-date-timefrom
feat/conditional-questions-4-file

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Part 4 of the conditional questions stack from #3123 (by Micke Nordin, with fixes by TimedIn and the review fixes). Based on #3835; the "Files changed" tab shows only this part.

Stack

  1. Conditional questions: base implementation plus support for radio and dropdown triggers #3833 Conditional questions: radio and dropdown triggers
  2. Conditional questions: checkboxes as trigger #3834 Conditional questions: checkboxes as trigger
  3. Conditional questions: date and time as trigger #3835 Conditional questions: date and time as trigger
  4. Conditional questions: file upload as trigger #3836 Conditional questions: file upload as trigger ← this PR
  5. Conditional questions: linear scale and color as trigger #3837 Conditional questions: linear scale and color as trigger
  6. Conditional questions: short and long text as trigger #3838 Conditional questions: short and long text as trigger

This PR

A file trigger shows a branch depending on whether a file was uploaded, so a branch can also stand for "no file uploaded".

  • an unanswered file trigger activates the "no file uploaded" branch, other trigger types activate nothing until answered;
  • uploads of the trigger are checked and stored like those of a file question (upload token of the same form);
  • docs and tests.

Tests

  • Unit tests: 612, all passing except the 15 IUserFolder errors main has as well.
  • php-cs-fixer, eslint and the build are clean.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 14.28% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from a9f1f27 to f0235a8 Compare November 4, 2026 14:07
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from 21c5283 to fe30885 Compare November 4, 2026 14:20
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from f0235a8 to a5dc275 Compare November 4, 2026 14:20
A file trigger activates a branch depending on whether a file was
uploaded, so a branch can also stand for "no file uploaded". Uploads
of the trigger are checked and stored like those of a file question.

The code comes from the original pull request #3123 by Micke Nordin
and TimedIn, with the review fixes applied.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from a5dc275 to 62a5b50 Compare November 4, 2026 16:51
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from fe30885 to f1898c5 Compare November 4, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant