Repository navigation
feat(rivetkit-core): run sqlite synchronously with commit tickets - #5883
eersnington wants to merge 1 commit into
Conversation
|
Review (updated) Overall this is a well-scoped, well-documented change. The fail-fast design ( Potential issues
Convention and parity
Concurrency
Tests to add (a) No security concerns. 🤖 Generated with Claude Code |
7261035 to
1d1d6c8
Compare
33bd98f to
18dce02
Compare
a2b9069 to
d471419
Compare
1d1d6c8 to
64ca955
Compare
|
Changes look good: no high-confidence bugs or CLAUDE.md compliance issues found in the supplied commit range. No Blocking, Should-fix, or Nit findings. Review limited to local code inspection; tests were not run. GitHub authentication was unavailable, so PR status and prior comments could not be verified. Copy prompt to fix all |
d471419 to
b159136
Compare
64ca955 to
bc14557
Compare
b159136 to
f2702ea
Compare
bc14557 to
7a32f03
Compare
f2702ea to
0210997
Compare
7a32f03 to
08d0868
Compare
0210997 to
cdcc709
Compare
08d0868 to
4cf6492
Compare
cdcc709 to
8f73549
Compare
ae39d9b to
88c2d79
Compare
341419b to
335d27e
Compare
335d27e to
d5c0ba5
Compare
execute_sync,exec_sync, andbegin_transaction_synctoSqliteDb.commit_ticketandwhen_durable, so an embedder can hold output until the writes it depends on are durable.abort_generation, which restarts the actor from durable state.sqlite_deferred_commitsto the actor config. It is off by default and is not user-facing.sqlite.sync_unsupported.sqlite.writer_busywhile a host-thread transaction is open. It waits for internal transactions, such as state saves.sqlite.statement_failed,sqlite.sync_unsupported,sqlite.deferred_commits_unsupported,sqlite.durability_failed,sqlite.invalid_commit_ticket.Rebased onto main.
Stack: #5882, #5883 (this PR), #5911.