Skip to content

feat(rivetkit): expose synchronous sqlite and commit tickets to native database providers - #5911

Draft
eersnington wants to merge 1 commit into
feat/sqlite-syncfrom
fix/envoy-late-frames
Draft

eersnington wants to merge 1 commit into
feat/sqlite-syncfrom
fix/envoy-late-frames

Conversation

@eersnington

@eersnington eersnington commented Oct 20, 2026 •

Copy link
Copy Markdown
Member
  • Exposes executeSync, execSync, beginTransactionSync, commitTicket, whenDurable, and abortGeneration on the native database provider.
  • Adds the matching calls to rivetkit-napi.
  • A provider opts in to deferred commits through an internal symbol. There is no new public actor option.
  • Wasm throws sqlite.sync_unsupported and sqlite.deferred_commits_unsupported.
  • This PR no longer holds the envoy-client fix. That fix merged in fix(envoy-client): drop trailing frames for completed HTTP requests #5936.

Rebased onto main.

Stack: #5882, #5883, #5911 (this PR).

@eersnington
eersnington force-pushed the fix/envoy-late-frames branch from 23abd46 to 95f6e2d Compare November 3, 2026 16:54
@eersnington eersnington changed the title fix(envoy-client): drop trailing frames for completed HTTP requests feat(rivetkit): expose synchronous sqlite and commit tickets to native database providers Nov 3, 2026
@RivetAgent

RivetAgent commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Looks good—no high-confidence issues found in the supplied commit range.

No issues found. Checked for bugs and CLAUDE.md compliance; no CLAUDE.md files were present.

Review limited to local code: GitHub authentication was unavailable, so PR status and prior comments could not be checked. Tests were not run.

Copy prompt to fix all
Fix all actionable findings in the latest Ironworks code review on PR rivet-dev/rivet#5911. Inspect every referenced location, address each finding without changing unrelated behavior, run the relevant tests, and summarize what changed.

@eersnington
eersnington force-pushed the fix/envoy-late-frames branch from 95f6e2d to 5663d2f Compare November 4, 2026 14:46
@eersnington
eersnington force-pushed the fix/envoy-late-frames branch 2 times, most recently from 622c921 to 5b9807a Compare November 8, 2026 14:29
@eersnington
eersnington force-pushed the fix/envoy-late-frames branch from e5ed391 to fbab8e1 Compare November 20, 2026 15:53
@eersnington
eersnington force-pushed the feat/sqlite-sync branch 2 times, most recently from 8f73549 to 341419b Compare November 20, 2026 19:20
@eersnington
eersnington force-pushed the fix/envoy-late-frames branch from fbab8e1 to 73f9252 Compare November 20, 2026 19:20
@eersnington
eersnington force-pushed the fix/envoy-late-frames branch from 73f9252 to 252d4af Compare November 20, 2026 19:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants