Repository navigation
Drop Silo GitBook links from the Cambrian agent kit page - #101
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
PR SummaryLow Risk Overview The iSEI and 5% fee bullets stay as plain text; other bullets (Medium, silostaking.io) are unchanged. This was the only GitBook usage in docs content. Reviewed by Cursor Bugbot for commit e79b5f8. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
This is a small, well-reasoned change. It removes the two silostaking.gitbook.io links from the Cambrian agent kit page and keeps the facts they supported. Nothing blocks merge, but there are a few follow-up notes about the links left in that list.
Findings: 0 blocking | 7 non-blocking | 2 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- REVIEW_GUIDELINES.md was empty, so no repo-specific review guidelines were applied beyond AGENTS.md.
- The OpenAI Codex second-opinion pass (codex-review.md) produced no output.
- The Cursor second-opinion pass (cursor-review.md) produced no output.
- The iSEI and 5% fee statements no longer cite a source. The 5% fee in particular is a third-party fee that can change, so consider citing an authoritative Silo source once one is available. If none can be found, consider dropping the exact figure or adding a caveat to check with Silo.
- llms-full.txt will keep the GitBook links until the weekly regenerate job runs. Given the security reason for this PR, consider triggering the regenerate-llms workflow manually through workflow_dispatch after merge.
- 2 suggestion(s)/nit(s) flagged inline on specific lines.
| - **iSEI token**: Represents your staked SEI plus auto-compounded rewards | ||
| - **No unbonding period**: [Immediate liquidity, unlike traditional staking](https://medium.com/@nordicmoney22/unleashing-the-power-of-liquid-staking-on-sei-4a1d045232e1) | ||
| - **5% fee**: [Annual management fee of 5% on rewards](https://silostaking.gitbook.io/silo-staking/general-faq) | ||
| - **5% fee**: Annual management fee of 5% on rewards |
There was a problem hiding this comment.
[nit] This states a specific fee figure that can change, and it now has no citation. Consider wording it so readers know to confirm current fees with Silo, for example "Silo charges a management fee on rewards (5% at the time of writing)."
| - **No unbonding period**: [Immediate liquidity, unlike traditional staking](https://medium.com/@nordicmoney22/unleashing-the-power-of-liquid-staking-on-sei-4a1d045232e1) | ||
| - **5% fee**: [Annual management fee of 5% on rewards](https://silostaking.gitbook.io/silo-staking/general-faq) | ||
| - **5% fee**: Annual management fee of 5% on rewards | ||
| - **MEV benefits**: [Validators share MEV profits with stakers](https://www.silostaking.io/) |
There was a problem hiding this comment.
[suggestion] The PR description says www.silostaking.io does not resolve, which makes this a dead outbound link in the same list. Consider removing it in this PR too, the same way you handled the GitBook links. Separately, the No unbonding period bullet links to a third-party Medium post rather than an authoritative source, which may be worth revisiting.
trade.xyz reported unauthorized changes to its GitBook docs today and warned users not to click links in them, so pages on docs.sei.io should not send readers to third-party GitBook spaces. The Cambrian agent kit page linked to silostaking.gitbook.io twice for the iSEI and 5% fee facts; these were the only GitBook links in our docs content.
This keeps both facts and drops the links. Silo's own domain (silostaking.io, still used by the MEV bullet) does not resolve, so there is no first-party page to point at instead. llms-full.txt still carries the old links and picks this up on the next weekly regenerate run, per AGENTS.md.