Repository navigation
chore(ci): reach the database over the tailnet when CI_DB_TAILNET is set - #9541
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryAdds optional Tailscale access before database work in the migration and docs workflows.
Reviews (1) · Last reviewed commit: "chore(ci): reach the database over the t..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate.ymlanddocs.ymljoin the tailnet (officialtailscale/github-action, pinned by SHA) before their first database connection, so database IP restrictions can admit the tailnet's app connector instead of ever-changing runner addressesCI_DB_TAILNETistrue: merging is a no-op, it can be verified on a staging deploy before any restriction depends on it, and unsetting it reverts instantlytag:ci), so no long-lived Tailscale secret is stored;--accept-routesbecause Linux nodes ignore app connector routes otherwiseci.ymlgrantid-token: writeand passTS_OAUTH_CLIENT_ID/TS_AUDIENCE; a called job requestingid-token: writewithout the caller granting it would fail the whole run at startupType of Change
Testing
actionlint -shellcheck= -pyflakes=(the CI invocation) clean on all workflowsscripts/migrations-workflow.test.ts,scripts/dev-deployment-workflow.test.ts,scripts/desktop-prune-workflow.test.ts: 20/20 passCI_DB_TAILNETunset the new steps are skipped, so behavior is unchanged until the variable is flipped and a staging deploy confirms the routeChecklist
test-auditauthoring gate)