Repository navigation
feat: add Analytics event detail and fix filters - #161
Open
MaxMichel2 wants to merge 1 commit into
Open
MaxMichel2 wants to merge 1 commit into
MaxMichel2 wants to merge 1 commit into
Conversation
Add parameter inspection and copying with stable recording UUIDs, saved list state, compact filtered counts and recoverable search/category/time filters. Expose read-only logger snapshots and explicit standalone sources instead of LocalAnalytics. Record sample seed events from an effect to avoid an observation/recomposition feedback loop. Validation: Analytics host tests and all 11 device tests passed, including clipboard, restoration and periodic expiry. Detekt, Konsist, API generation/compatibility and sample debug build passed. Checked settled list/detail captures in light and dark; updated graph with unchanged-document recovery. Native iOS execution, TalkBack and large-font checks remain pending; light system-bar contrast is scheduled for checkpoint 9.
|
|
||
| public final class AnalyticsScreenKt { | ||
| method @KotlinOnly @androidx.compose.runtime.Composable public static void AnalyticsScreen(kotlinx.collections.immutable.PersistentList<com.worldline.devview.analytics.model.AnalyticsLogType> highlightedAnalyticsLogTypes, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.unit.Dp bottomPadding); | ||
| method @KotlinOnly @androidx.compose.runtime.Composable public static void AnalyticsScreen(kotlinx.collections.immutable.PersistentList<com.worldline.devview.analytics.model.AnalyticsLogType> highlightedAnalyticsLogTypes, optional androidx.compose.ui.Modifier modifier, optional androidx.compose.ui.unit.Dp bottomPadding, optional java.util.List<com.worldline.devview.analytics.model.AnalyticsLog> logs); |
There was a problem hiding this comment.
This API change removes LocalAnalytics, but the root README.md still tells users to call CompositionLocalProvider(LocalAnalytics provides AnalyticsLogger.logs). Following that setup now fails to compile.
The repository requires Markdown examples to match the current API. Update the root example before merging to explain that the registered module needs no provider.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checkpoint 4 only, compared with
refactor/featureflip-segmented-control.Validation
Dependency and migration
Depends on #160. Merge order: #157 → #159 → #160 → this PR. The dependency note is informational, not enforced; no gh-stack metadata or earlier PRs were changed.
Alpha08 migration: replace writes to AnalyticsLogger.logs with AnalyticsLogger.log(). Remove LocalAnalytics providers; standalone custom sources pass AnalyticsScreen(logs = yourList, ...). Events remain in memory only.
The code changes appear sound, but the root setup example must be updated to satisfy the repository’s documentation requirement before merging.
Findings
Summary
Adds Analytics event details and updates how events are recorded and filtered.
MaxMichel2 explicitly describes the breaking API changes as intentional and supplies an alpha08 migration. MaxMichel2 also identifies native iOS, TalkBack and enlarged-font checks as pending, and defers light system-bar contrast to checkpoint 9.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A["AnalyticsLogger.log(event)"] --> B["Copy parameters and assign UUID"] B --> C["Read-only history"] C --> D["Search and filter events"] D --> E["Filtered counts and rows"] E --> F["Select UUID"] C --> G["Find selected UUID"] F --> G G --> H["Event details or unavailable state"] H --> I["Copy event"]Reviews (1) · Last reviewed commit: ":sparkles: Add Analytics event detail an..." · Reviewed by Greptile