Repository navigation
feat: a product's own stylesheets, served after the platform's - #90
Merged
Merged
Conversation
`DiagramProfile.clientStylesheets`, and the same on `SidecarProfileInput`: absolute paths of stylesheets the webview links after the bundle's own, stock or `clientAssets` alike, each file's directory added to the resource roots. The platform already writes `<kind>-node`, `edge-role-<role>` and the family classes on what it draws and styles none of them; this is where a product says what they look like, without composing a webview bundle of its own for one stylesheet. Data only, like every other asset field. Claude-Session: https://claude.ai/code/session_012yAjXyWw6JyWsXvHG3cG9c
This was referenced Oct 22, 2026
…on README row Review of #90: an unreadable stylesheet was reported as a `clientAssets` path, and the extension's README profile table lacked `clientStylesheets`. Claude-Session: https://claude.ai/code/session_01E8WfqKknDNN6xpNVcJL5K8
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiagramProfile.clientStylesheets(andSidecarProfileInput.clientStylesheets): absolute paths of a product's stylesheets, linked into the webview after the bundle's own stylesheet, stock orclientAssetsalike, with each file's directory added tolocalResourceRoots.The platform writes
<kind>-nodefor a kind of its own,edge-role-<role>for what a connection is, and the family classes, and styles none of them. A product whose graph has fifteen connection types that must be told apart (a specification'srefines,verifies,conflicts-with) says what they look like here, in CSS, instead of composing a whole webview bundle for one stylesheet. Data only, as every asset field is.Tests: four cases in
diagram-editor-provider-client-assets.test.ts(order after the stock stylesheet with the mtime cache-bust, the directory in the roots, after a consumer bundle's stylesheet, and byte-identical output when none are declared). Typecheck, all suites and the neutrality gates pass.First of the platform changes for the NDF document diagram (
ide/ndf-ide/ndf-ide-plan.md, N3).https://claude.ai/code/session_012yAjXyWw6JyWsXvHG3cG9c